Update runc to 00dc70017d222b178a002ed30e9321b126#2674
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 21, 2018
Merged
Update runc to 00dc70017d222b178a002ed30e9321b126#2674crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Michael Crosby <[email protected]>
Member
|
LGTM |
estesp
approved these changes
Sep 20, 2018
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; seems like this has no material code changes; only comments and docs. Is this just to line up with another vendoring commit?
Codecov Report
@@ Coverage Diff @@
## master #2674 +/- ##
=========================================
- Coverage 45.04% 45% -0.04%
=========================================
Files 92 92
Lines 10106 10114 +8
=========================================
Hits 4552 4552
- Misses 4834 4842 +8
Partials 720 720
Continue to review full report at Codecov.
|
Member
Author
|
Not just vendoring, this is how we pin to a runc version. Most of the changes and fixes are in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Crosby [email protected]