runhcs-shim improvements and fixes to ctr#2670
Merged
dmcgowan merged 2 commits intocontainerd:masterfrom Sep 20, 2018
Merged
Conversation
Signed-off-by: Justin Terry (VM) <[email protected]>
1. Fixes bugs in ctr run that were introduced by 1d9b969 2. Adds support for the --isolated flag that runs Windows HyperV cotainers instead of process isolated containers on Windows. Signed-off-by: Justin Terry (VM) <[email protected]>
jterry75
force-pushed
the
runhcs_stop_success
branch
from
bfc9c69 to
547bb94
Compare
Codecov Report
@@ Coverage Diff @@
## master #2670 +/- ##
=========================================
- Coverage 45.04% 45% -0.04%
=========================================
Files 92 92
Lines 10106 10114 +8
=========================================
Hits 4552 4552
- Misses 4834 4842 +8
Partials 720 720
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft/hcsshimgo-runhcspackage.cotainers instead of process isolated containers on Windows.