Remove a TODO from the code comments that is complete#2669
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 21, 2018
Merged
Remove a TODO from the code comments that is complete#2669crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
WithUser... helpers do support non-snapshot rootfs now. Signed-off-by: Phil Estes <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2669 +/- ##
=======================================
Coverage 45.04% 45.04%
=======================================
Files 92 92
Lines 10106 10106
=======================================
Hits 4552 4552
Misses 4834 4834
Partials 720 720
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithUser... helpers do support non-snapshot rootfs now.
Signed-off-by: Phil Estes [email protected]