Skip to content

Update version for v1.2.0-rc.0#2666

Merged
dmcgowan merged 2 commits intocontainerd:masterfrom
dmcgowan:update-version-1.2-rc.0
Sep 20, 2018
Merged

Update version for v1.2.0-rc.0#2666
dmcgowan merged 2 commits intocontainerd:masterfrom
dmcgowan:update-version-1.2-rc.0

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 19, 2018

Codecov Report

Merging #2666 into master will increase coverage by 6.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2666      +/-   ##
==========================================
+ Coverage    41.8%   48.75%   +6.95%     
==========================================
  Files          65       85      +20     
  Lines        8877     8048     -829     
==========================================
+ Hits         3711     3924     +213     
+ Misses       4617     3403    -1214     
- Partials      549      721     +172
Flag Coverage Δ
#linux 48.75% <ø> (?)
#windows ?
Impacted Files Coverage Δ
remotes/docker/auth.go 63.82% <0%> (-3.97%) ⬇️
remotes/docker/status.go 21.42% <0%> (-3.58%) ⬇️
platforms/cpuinfo.go 4.65% <0%> (-1.01%) ⬇️
log/context.go 36.84% <0%> (-0.66%) ⬇️
namespaces/context.go 55% <0%> (-0.56%) ⬇️
errdefs/grpc.go 74.6% <0%> (-0.4%) ⬇️
metadata/namespaces.go 0% <0%> (ø) ⬆️
namespaces/grpc.go 62.5% <0%> (ø) ⬆️
services/server/config.go 0% <0%> (ø) ⬆️
content/content.go 0% <0%> (ø) ⬆️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b42fc...65e0214. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@dmcgowan dmcgowan force-pushed the update-version-1.2-rc.0 branch from 6e46565 to 509afdc Compare September 20, 2018 18:10
Fix ordering for Xuean Yan

Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan force-pushed the update-version-1.2-rc.0 branch from 509afdc to 65e0214 Compare September 20, 2018 18:23
@dmcgowan dmcgowan merged commit 99fc40f into containerd:master Sep 20, 2018
@dmcgowan dmcgowan deleted the update-version-1.2-rc.0 branch September 10, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants