Update mailmap#2665
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Sep 19, 2018
Merged
Conversation
Add consistent contributor names and emails Signed-off-by: Derek McGowan <[email protected]>
Member
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2665 +/- ##
==========================================
- Coverage 44.94% 44.89% -0.05%
==========================================
Files 92 92
Lines 10048 10232 +184
==========================================
+ Hits 4516 4594 +78
- Misses 4816 4915 +99
- Partials 716 723 +7
Continue to review full report at Codecov.
|
estesp
approved these changes
Sep 19, 2018
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; can wait to merge until tomorrow for any responses from contributors on name format
Member
Author
|
Merging this for the rc, please comment here if anything doesn't look right and I will update for the final release notes. |
Member
|
@dmcgowan Please change to "Xuean Yan", thanks. |
Contributor
|
Yes, I have nothing to change. |
Contributor
|
@dmcgowan It looks great. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add consistent contributor names and emails
before cleanup https://gist.github.com/dmcgowan/20bc5d9e19fd91136135586465e31e81
ping @nashasha1 @lifubang @jianliao82 @yanxuean @mirake please let me know if this is not how you want your name displayed in the release notes (name on the left is what gets used).