Skip to content

Add nosuid,noexec,nodev to proc#2664

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:proc
Sep 19, 2018
Merged

Add nosuid,noexec,nodev to proc#2664
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:proc

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

This is to match the same mount options as the host.

Signed-off-by: Michael Crosby [email protected]

This is to match the same mount options as the host.

Signed-off-by: Michael Crosby <[email protected]>
@dmcgowan dmcgowan added this to the 1.2 milestone Sep 19, 2018
@dmcgowan
Copy link
Copy Markdown
Member

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2664 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2664      +/-   ##
==========================================
+ Coverage   44.94%   44.94%   +<.01%     
==========================================
  Files          92       92              
  Lines       10048    10049       +1     
==========================================
+ Hits         4516     4517       +1     
  Misses       4816     4816              
  Partials      716      716
Flag Coverage Δ
#linux 48.69% <100%> (-0.02%) ⬇️
#windows 41.67% <100%> (ø) ⬆️
Impacted Files Coverage Δ
oci/spec.go 93.71% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac5ac6...94c33d4. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants