[release/1.1] Backported: check exists on content commit + testcase#2654
Merged
crosbymichael merged 2 commits intocontainerd:release/1.1from Sep 18, 2018
Merged
Conversation
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
reviewed
Sep 17, 2018
Member
There was a problem hiding this comment.
Looks like this line will also need to have an import for ocispec
Member
Author
There was a problem hiding this comment.
Yeah; been sitting on it as I wanted to make sure if it was just the import as it seems the write style has changed since 1.1.x branch, and maybe it's easier to make the test write in the old style (without the ocispec import?)
estesp
force-pushed
the
cherrypick-commit-fix
branch
from
a70bf0b to
efeae61
Compare
Signed-off-by: Derek McGowan <[email protected]>
estesp
force-pushed
the
cherrypick-commit-fix
branch
from
efeae61 to
56f9c44
Compare
Member
Author
|
@dmcgowan the test is now passing using the older API style for content store; would love your review to make sure it looks right to you |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This was referenced Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick/backport of #2642 for the release/1.1 branch