typo fix oci/typo_spec_opts_test#2653
Merged
estesp merged 2 commits intocontainerd:masterfrom Sep 20, 2018
Merged
Conversation
estesp
previously approved these changes
Sep 17, 2018
Signed-off-by: Yongxin Li <[email protected]>
Contributor
Author
|
@estesp tks, already signed~ |
|
|
||
| if len(s.Process.Env) != 2 { | ||
| t.Fatal("coudn't unset") | ||
| t.Fatal("could't unset") |
Signed-off-by: Yongxin Li <[email protected]>
Contributor
Author
|
@crosbymichael tks, have been recommited~ |
Codecov Report
@@ Coverage Diff @@
## master #2653 +/- ##
==========================================
- Coverage 47.52% 45.04% -2.48%
==========================================
Files 87 92 +5
Lines 8211 10106 +1895
==========================================
+ Hits 3902 4552 +650
- Misses 3591 4834 +1243
- Partials 718 720 +2
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.