Vendor in runtime spec referencing windows namespace#2644
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Sep 15, 2018
Merged
Vendor in runtime spec referencing windows namespace#2644dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
Contributor
Author
Contributor
Author
dmcgowan
requested changes
Sep 13, 2018
Member
|
The DCO seems to require a blank space between the subject and sign off. We can look into fixing this but when you push up the other change do you mind adding a blank line in your commit message after the subject to make the message validator happy. |
Signed-off-by: Madhan Raj Mookkandy <[email protected]>
madhanrm
force-pushed
the
vendor_win
branch
from
906e384 to
744d93e
Compare
Contributor
Author
|
ping @dmcgowan can you approve this PR? |
Contributor
Author
Member
|
LGTM |
Contributor
Author
|
Thanks @dmcgowan @jhowardmsft @crosbymichael |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Madhan Raj Mookkandy [email protected]