Skip to content

Don't start top container in test#2638

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:daemon-root
Sep 12, 2018
Merged

Don't start top container in test#2638
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:daemon-root

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Signed-off-by: Michael Crosby [email protected]

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 12, 2018

Codecov Report

Merging #2638 into master will decrease coverage by 3.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2638      +/-   ##
==========================================
- Coverage   47.48%   43.76%   -3.72%     
==========================================
  Files          87       94       +7     
  Lines        8203    10305    +2102     
==========================================
+ Hits         3895     4510     +615     
- Misses       3588     5075    +1487     
  Partials      720      720
Flag Coverage Δ
#linux 47.48% <ø> (ø) ⬆️
#windows 40.42% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/compression/compression.go 42.64% <0%> (-8.27%) ⬇️
content/local/writer.go 52.63% <0%> (-7.37%) ⬇️
archive/tar.go 43.13% <0%> (-6.87%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/store.go 48.76% <0%> (-4.77%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0f83a...700d8d3. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

LGTM

@dmcgowan dmcgowan merged commit 66b984e into containerd:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants