[release/1.1] Backport: With-helper for supplemental gid support#2637
Merged
dmcgowan merged 1 commit intocontainerd:release/1.1from Sep 12, 2018
Merged
Conversation
[Backported to release/1.1] Can be used to conform to Docker engine behavior of adding additional GIDs to spec when found in /etc/group of image filesystem Signed-off-by: Phil Estes <[email protected]>
estesp
force-pushed
the
cherrypick-supplemental-grps
branch
from
821ba91 to
19735b5
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.1 #2637 +/- ##
===============================================
- Coverage 49.27% 48.94% -0.33%
===============================================
Files 85 85
Lines 7546 7596 +50
===============================================
Hits 3718 3718
- Misses 3150 3200 +50
Partials 678 678
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This was referenced Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Backported to release/1.1]
Can be used to conform to Docker engine behavior of adding additional
GIDs to spec when found in /etc/group of image filesystem
Signed-off-by: Phil Estes [email protected]