Add optional install path #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to consume the install functionality but also install to other areas instead of the managed `/opt` dir. ```bash > ctr install --path /usr/local ``` Signed-off-by: Michael Crosby <[email protected]>
|
You just can't win with CI on this one...give up all hope now. |
|
Things were acting weird last night, not getting the CI status in other projects and now on containerd today. Not sure what's up. |
crosbymichael
force-pushed
the
install-path
branch
from
7738dd2 to
60d13d6
Compare
|
Travis had some sort of outage yesterday and I think things are taking a while to settle back to normal |
Codecov Report
@@ Coverage Diff @@
## master #2630 +/- ##
=========================================
Coverage ? 47.77%
=========================================
Files ? 87
Lines ? 8153
Branches ? 0
=========================================
Hits ? 3895
Misses ? 3538
Partials ? 720
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to consume the install functionality but also install
to other areas instead of the managed
/optdir.> ctr install --path /usr/localSigned-off-by: Michael Crosby [email protected]