fix typo#2621
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 13, 2018
Merged
Conversation
AkihiroSuda
requested changes
Sep 8, 2018
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Please don't modify pb.go manually
Contributor
Author
|
revert the pb.go, thanks a lot |
Member
|
The CI DCO checker didn't seem to like the signoff, try adding the brackets |
Member
|
maybe we can use |
fix typo Signed-off-by: jian liao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2621 +/- ##
=======================================
Coverage 43.76% 43.76%
=======================================
Files 94 94
Lines 10305 10305
=======================================
Hits 4510 4510
Misses 5075 5075
Partials 720 720
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix typo
Signed-off-by: jian liao [email protected]