Skip to content

Typo fix#2616

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
tunblr:master
Sep 20, 2018
Merged

Typo fix#2616
crosbymichael merged 1 commit intocontainerd:masterfrom
tunblr:master

Conversation

@tunblr
Copy link
Copy Markdown

@tunblr tunblr commented Sep 7, 2018

Signed-off-by: Lihua Tang [email protected]

@AkihiroSuda
Copy link
Copy Markdown
Member

needs make proto

@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 19, 2018

@Lihua93 are you able to update this PR per @AkihiroSuda's comment? You must run make proto and commit the output files changed as well.

Signed-off-by: Lihua Tang <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2616 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2616   +/-   ##
=======================================
  Coverage   45.04%   45.04%           
=======================================
  Files          92       92           
  Lines       10106    10106           
=======================================
  Hits         4552     4552           
  Misses       4834     4834           
  Partials      720      720
Flag Coverage Δ
#linux 48.78% <ø> (+0.02%) ⬆️
#windows 41.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308d3cb...af23a4c. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 1586130 into containerd:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants