Fix 'forward' typos#2615
Merged
estesp merged 1 commit intocontainerd:masterfrom Sep 7, 2018
Merged
Conversation
AkihiroSuda
previously requested changes
Sep 7, 2018
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
please run 'make protos' when making changes to proto files
tossmilestone
force-pushed
the
fix-forward-typo
branch
from
7011a57 to
69330eb
Compare
Contributor
Author
|
@AkihiroSuda thanks for your review, updated then. |
Signed-off-by: Xiaoxi He <[email protected]>
tossmilestone
force-pushed
the
fix-forward-typo
branch
from
69330eb to
9f81700
Compare
Codecov Report
@@ Coverage Diff @@
## master #2615 +/- ##
==========================================
+ Coverage 44.03% 44.36% +0.33%
==========================================
Files 94 94
Lines 10235 10381 +146
==========================================
+ Hits 4507 4606 +99
- Misses 5008 5054 +46
- Partials 720 721 +1
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiaoxi He [email protected]