Fix typo in contirb dir#2612
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 7, 2018
Merged
Conversation
Member
|
Please squash the commits to a single commit. Also, it would be appreciated if you could squash your colleagues' typo-fix PRs as well. |
nashasha1
force-pushed
the
fix/contrib-typo
branch
from
99c5cc1 to
e7858b6
Compare
Contributor
Author
|
@AkihiroSuda squash to one commit. Thanks for your reply. |
Contributor
Author
|
/retest |
AkihiroSuda
requested changes
Sep 7, 2018
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
commit needs to be signed
Signed-off-by: nashasha1 <[email protected]>
nashasha1
force-pushed
the
fix/contrib-typo
branch
from
e7858b6 to
7f03ad6
Compare
Contributor
Author
|
@AkihiroSuda Forgot it. Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #2612 +/- ##
=======================================
Coverage 44.03% 44.03%
=======================================
Files 94 94
Lines 10235 10235
=======================================
Hits 4507 4507
Misses 5008 5008
Partials 720 720
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type:
./contrib/nvidia/nvidia.go (explaination -> explanation)
./contrib/seccomp/seccomp.go (formated -> formatted)
./remotes/docker/fetcher.go (considerd -> considered)
./remotes/docker/httpreadseeker.go (satisified -> satisfied)