Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait before start with runtime root test #2603

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

crosbymichael
Copy link
Member

Signed-off-by: Michael Crosby [email protected]

@codecov-io
Copy link

codecov-io commented Aug 31, 2018

Codecov Report

Merging #2603 into master will decrease coverage by 3.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2603      +/-   ##
==========================================
- Coverage    47.5%   44.03%   -3.48%     
==========================================
  Files          87       94       +7     
  Lines        8150    10235    +2085     
==========================================
+ Hits         3872     4507     +635     
- Misses       3556     5008    +1452     
+ Partials      722      720       -2
Flag Coverage Δ
#linux 47.5% <ø> (ø) ⬆️
#windows 40.66% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/compression/compression.go 42.64% <0%> (-8.27%) ⬇️
content/local/writer.go 52.63% <0%> (-7.37%) ⬇️
archive/tar.go 43.13% <0%> (-6.87%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/store.go 48.76% <0%> (-4.77%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5aebde...a3d3055. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit acced5d into containerd:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants