[release/1.1] Cherrypick: Support >= 128 layers in overlayfs snapshots#2600
Merged
crosbymichael merged 2 commits intocontainerd:release/1.1from Sep 7, 2018
Merged
Conversation
Member
|
Thanks for the consideration about 1.1 version. 😄 |
Member
|
failed caused by missing maybe we add other patch for this? |
This allows non-privileged users to use containerd. If a non root user tried to set a negative oom score adjustment, it will fail. Containerd should not fail if running rootless. This is part of a larger track of work integrating containerd into Cloudfoundry's garden with support for rootless. [#156343443] Signed-off-by: Danail Branekov <[email protected]> Signed-off-by: Claudia Beresford <[email protected]>
Auto-detect longest common dir in lowerdir option and compact it if the option size is hitting one page size. If does, Use chdir + CLONE to do mount thing to avoid hitting one page argument buffer in linux kernel mount. Signed-off-by: Wei Fu <[email protected]>
estesp
force-pushed
the
cherrypick-overlayfs-mounts
branch
from
eb83b71 to
8a2991c
Compare
Member
Author
|
Thanks @fuweid ; I added the other required dependent commit |
Codecov Report
@@ Coverage Diff @@
## release/1.1 #2600 +/- ##
===============================================
- Coverage 50.11% 49.27% -0.85%
===============================================
Files 75 85 +10
Lines 7297 7546 +249
===============================================
+ Hits 3657 3718 +61
- Misses 2965 3150 +185
- Partials 675 678 +3
Continue to review full report at Codecov.
|
Member
|
LGTM 😄 |
Member
|
LGTM |
Member
|
any update on this PR? 😄 |
Member
AkihiroSuda
approved these changes
Sep 7, 2018
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM
Do we want this for 1.0 as well?
Member
The 1.1 containerd has upgraded go version from 1.9 to 1.10. The commit has only been tested in go1.10. No sure it can work well in go1.9. If we have to, I can test it. and cc @estesp |
This was referenced Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this fix makes sense in the 1.1.x line as well
Auto-detect longest common dir in lowerdir option and compact it if the
option size is hitting one page size. If does, Use chdir + CLONE to do
mount thing to avoid hitting one page argument buffer in linux kernel
mount.
Signed-off-by: Wei Fu [email protected]