Skip to content

Add Windows build status#2593

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
jterry75:add_win_build
Aug 30, 2018
Merged

Add Windows build status#2593
crosbymichael merged 1 commit intocontainerd:masterfrom
jterry75:add_win_build

Conversation

@jterry75
Copy link
Copy Markdown
Contributor

Signed-off-by: Justin Terry (VM) [email protected]

Signed-off-by: Justin Terry (VM) <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2593 into master will increase coverage by 3.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2593      +/-   ##
==========================================
+ Coverage   40.97%   44.05%   +3.08%     
==========================================
  Files          69       98      +29     
  Lines        8350    10130    +1780     
==========================================
+ Hits         3421     4463    +1042     
- Misses       4385     4945     +560     
- Partials      544      722     +178
Flag Coverage Δ
#linux 47.79% <ø> (?)
#windows 40.97% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mount/temp_unix.go 0% <0%> (ø)
sys/reaper_linux.go 0% <0%> (ø)
services/server/server_linux.go 0% <0%> (ø)
sys/env.go 100% <0%> (ø)
oci/spec_opts_unix.go 17.59% <0%> (ø)
sys/stat_unix.go 0% <0%> (ø)
sys/reaper.go 0% <0%> (ø)
sys/fds.go 0% <0%> (ø)
sys/proc.go 0% <0%> (ø)
sys/mount_linux.go 0% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89ba5e...85eb2c3. Read the comment docs.

Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 7cb847b into containerd:master Aug 30, 2018
@jterry75 jterry75 deleted the add_win_build branch August 30, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants