Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release script #2591

Merged
merged 3 commits into from
Aug 29, 2018
Merged

Conversation

dmcgowan
Copy link
Member

Saves a step of adding the first line when creating a tag, this gets us a step close to auto tag creation in the release script.

Added option to create links in the changelog. This ensures that the links both exist in the git tag and in the Github release notes, additionally this ensures that the dependencies on Github are also linked, avoiding the creation of incorrect PR links for subprojects.

Updated mailmap to deduplicate John and use a real name for @kadisi (let me know if you would prefer to not have this here or I am using the wrong name)

Signed-off-by: Derek McGowan <[email protected]>
Fix spacing on releases.
Add tag prefix line

Signed-off-by: Derek McGowan <[email protected]>
Allows creating links in changelog, similar to what Github does
for markdown but works for dependencies as well.

Signed-off-by: Derek McGowan <[email protected]>
@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #2591 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2591   +/-   ##
=======================================
  Coverage   44.05%   44.05%           
=======================================
  Files          98       98           
  Lines       10130    10130           
=======================================
  Hits         4463     4463           
  Misses       4945     4945           
  Partials      722      722
Flag Coverage Δ
#linux 47.79% <ø> (ø) ⬆️
#windows 40.97% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29eab28...69e7c77. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit d89ba5e into containerd:master Aug 29, 2018
@dmcgowan dmcgowan deleted the update-release-script branch September 10, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants