Add a manifest filter limiting the number of matches#2586
Add a manifest filter limiting the number of matches#2586crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
dmcgowan
force-pushed
the
platform-filter-limit
branch
2 times, most recently
from
1dd8532 to
4d6ff83
Compare
dmcgowan
changed the title
|
Updated the implementation to just make a new handler wrapper which only operates on manifest lists and indexes since those are the types which need to have the limit applied. |
Codecov Report
@@ Coverage Diff @@
## master #2586 +/- ##
=======================================
Coverage 44.07% 44.07%
=======================================
Files 96 96
Lines 10125 10125
=======================================
Hits 4463 4463
Misses 4940 4940
Partials 722 722
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Include a statement here about favoring entries that appear first in the manifests.
Adds a manifest filter for pulling which ensures only one manifest from a manifest list is pulled even when multiple matches. Removes unused filter platform list. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
platform-filter-limit
branch
from
4d6ff83 to
3d1082e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2586 +/- ##
=======================================
Coverage 44.07% 44.07%
=======================================
Files 96 96
Lines 10125 10125
=======================================
Hits 4463 4463
Misses 4940 4940
Partials 722 722
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #2586 +/- ##
=======================================
Coverage 44.07% 44.07%
=======================================
Files 96 96
Lines 10125 10125
=======================================
Hits 4463 4463
Misses 4940 4940
Partials 722 722
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2586 +/- ##
=======================================
Coverage 44.07% 44.07%
=======================================
Files 96 96
Lines 10125 10125
=======================================
Hits 4463 4463
Misses 4940 4940
Partials 722 722
Continue to review full report at Codecov.
|
|
LGTM |
6 participants
Adds a manifest filter for pulling which ensures only a manifest from a manifest list is pulled even when multiple matches. Removes unused filter platform list.
This prevents pulling multiple variants on arm if multiple are supported and included in an image, but only one is needed. This could also prevent pulling both Linux and Window images once LCOW support is added and only 1 image is required.