Skip to content

Add WithAmbientCapabilities opt#2585

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:low-ports
Aug 27, 2018
Merged

Add WithAmbientCapabilities opt#2585
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:low-ports

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Closes #2516

This can be used for non-root users binding to low ports.

Signed-off-by: Michael Crosby [email protected]

Comment thread oci/spec_opts_unix.go Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo process

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 27, 2018

Codecov Report

Merging #2585 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2585      +/-   ##
==========================================
- Coverage   44.13%   44.07%   -0.06%     
==========================================
  Files          96       96              
  Lines       10120    10125       +5     
==========================================
- Hits         4466     4463       -3     
- Misses       4933     4940       +7     
- Partials      721      722       +1
Flag Coverage Δ
#linux 47.79% <0%> (-0.03%) ⬇️
#windows 40.98% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
oci/spec_opts_unix.go 17.59% <0%> (-0.21%) ⬇️
gc/scheduler/scheduler.go 67.3% <0%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3f87e...4b9b3e8. Read the comment docs.

Closes containerd#2516

This can be used for non-root users binding to low ports.

Signed-off-by: Michael Crosby <[email protected]>
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants