Add platform match comparer interface#2581
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Aug 27, 2018
Merged
Conversation
Adds a new platform interface for matching and comparing platforms. This new interface allows both filtering and ordering of platforms to support running multiple platform and choosing the best platform. Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2581 +/- ##
========================================
- Coverage 44.59% 44.1% -0.5%
========================================
Files 95 96 +1
Lines 10007 10120 +113
========================================
Hits 4463 4463
- Misses 4822 4935 +113
Partials 722 722
Continue to review full report at Codecov.
|
estesp
approved these changes
Aug 27, 2018
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; I like this model and seems to match the discussion that went back and forth in the issue (client-specified, and easy to override/customize based on client requirements/needs)
Member
|
LGTM |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new platform interface for matching and comparing platforms.
This new interface allows both filtering and ordering of platforms to support running multiple platform and choosing the best platform.
Fixes issue where
docker.io/library/alpineimages couldn't be pulled on armv7 machinesCloses #2029
Allows support for custom ordering for Windows using build version