fix when --config provided, don't need Image/RootFS#2579
Merged
crosbymichael merged 2 commits intocontainerd:masterfrom Sep 10, 2018
Merged
fix when --config provided, don't need Image/RootFS#2579crosbymichael merged 2 commits intocontainerd:masterfrom
crosbymichael merged 2 commits intocontainerd:masterfrom
Conversation
Signed-off-by: Lifubang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2579 +/- ##
=======================================
Coverage 44.59% 44.59%
=======================================
Files 95 95
Lines 10007 10007
=======================================
Hits 4463 4463
Misses 4822 4822
Partials 722 722
Continue to review full report at Codecov.
|
Contributor
Author
|
These two commands have the same effects. So I think Image/RootFS param is not required when --config is pass to ctr. |
estesp
reviewed
Sep 5, 2018
| id = context.Args().Get(1) | ||
| args = context.Args()[2:] | ||
| id string | ||
| Config = context.IsSet("config") |
Member
There was a problem hiding this comment.
I don't think Config should be capitalized
Contributor
Author
There was a problem hiding this comment.
Thank you for your careful review.
Signed-off-by: Lifubang <[email protected]>
lifubang
commented
Sep 5, 2018
Contributor
Author
lifubang
left a comment
lifubang
left a comment
There was a problem hiding this comment.
Config -> config is finished.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lifubang [email protected]
After Merged pull request #2544
When run a command:
ctr run --config ./config.json --rootfs ./rootfs redis
or
ctr run --config ./config.json docker.io/library/redis:latest redis
The param Image/RootFS will be ignored. It will make the user puzzled when Image/RootFS's value is different from root.path in config.json.
I think pr #2544 may be can improved with a different solution, or if you accept pr #2544, you need to consider this PR.
Please check it. Thanks.
After this PR, more improves will be achieved, such as: ctr run --help, ctr c create --help.