Remove and create workdir if state dir does not exist#2575
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Aug 27, 2018
Merged
Remove and create workdir if state dir does not exist#2575dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2575 +/- ##
=======================================
Coverage 44.59% 44.59%
=======================================
Files 95 95
Lines 10007 10007
=======================================
Hits 4463 4463
Misses 4822 4822
Partials 722 722
Continue to review full report at Codecov.
|
dmcgowan
reviewed
Aug 27, 2018
Member
There was a problem hiding this comment.
paths was already initialized with this, is paths supposed to start off empty now?
This is the case where the work dir could still exist if a machine reboots, reseting the state dir. On container creation, we should just clear out the work dir. Signed-off-by: Michael Crosby <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2575 +/- ##
==========================================
- Coverage 44.13% 40.98% -3.15%
==========================================
Files 96 68 -28
Lines 10120 8347 -1773
==========================================
- Hits 4466 3421 -1045
+ Misses 4933 4382 -551
+ Partials 721 544 -177
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the case where the work dir could still exist if a machine
reboots, reseting the state dir. On container creation, we should just
clear out the work dir.
Signed-off-by: Michael Crosby [email protected]