support relative rootfs path in ctr#2573
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Aug 27, 2018
Merged
Conversation
Signed-off-by: Lifubang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2573 +/- ##
=======================================
Coverage 44.59% 44.59%
=======================================
Files 95 95
Lines 10007 10007
=======================================
Hits 4463 4463
Misses 4822 4822
Partials 722 722
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Aug 24, 2018
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lifubang [email protected]
When use --rootfs in ctr run command, rootfs path can't support relative path.
I think we should support relative path, but not only absolute path.
Fail When use relative path:
root@dockerdemo:/opt/runctest/redis# ~/gocode/src/github.com/containerd/containerd-v-1-1-3/bin/ctr run -c ./config.json -t --rootfs ./rootfs redis
ctr: OCI runtime create failed: container_linux.go:336: starting container process caused "exec: "/usr/local/bin/redis-server": stat /usr/local/bin/redis-server: no such file or directory": unknown
Succ When use absolute path:
root@dockerdemo:/opt/runctest/redis# ~/gocode/src/github.com/containerd/containerd-v-1-1-3/bin/ctr run -c ./config.json -t --rootfs /opt/runctest/redis/rootfs redis
1:C 23 Aug 01:36:37.246 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
Succ After fix:
root@dockerdemo:/opt/runctest/redis# ~/gocode/src/github.com/containerd/containerd-lifubang/bin/ctr run -c ./config.json -t --rootfs ./rootfs redis
1:C 23 Aug 02:59:44.549 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo