Some performance optimization when there are lots of containers to list#2566
Closed
lifubang wants to merge 2 commits intocontainerd:masterfrom
Closed
Some performance optimization when there are lots of containers to list#2566lifubang wants to merge 2 commits intocontainerd:masterfrom
lifubang wants to merge 2 commits intocontainerd:masterfrom
Conversation
Signed-off-by: Lifubang <[email protected]>
lifubang
force-pushed
the
containerinfo
branch
from
6e97382 to
6b42e88
Compare
Signed-off-by: Lifubang <[email protected]>
lifubang
force-pushed
the
containerinfo
branch
from
6b42e88 to
995d276
Compare
Member
|
I think this is a good idea, thinking more on how we want to handle this with the client methods |
crosbymichael
added a commit
to crosbymichael/containerd
that referenced
this pull request
May 10, 2019
Closes containerd#2566 This provides faster lookups and lists for ctr commands. Signed-off-by: Michael Crosby <[email protected]>
tussennet
pushed a commit
to tussennet/containerd
that referenced
this pull request
Sep 11, 2020
Closes containerd#2566 This provides faster lookups and lists for ctr commands. Signed-off-by: Michael Crosby <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When use 'ctr c info ':
The result of api named Get contains all container info, we don't need to call Get API again.
When use 'ctr c ls':
The result of api named List contains all container's info, we don't need to call Get API for each container.
This is useful when there are lots of containers to list.
Please check it, thanks.