Skip to content

Fix windows interactive consoles#2562

Merged
estesp merged 3 commits intocontainerd:masterfrom
crosbymichael:console
Aug 22, 2018
Merged

Fix windows interactive consoles#2562
estesp merged 3 commits intocontainerd:masterfrom
crosbymichael:console

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

No description provided.

This fixes interactive consoles in windows

Signed-off-by: Michael Crosby <[email protected]>
Signed-off-by: Michael Crosby <[email protected]>
@jterry75
Copy link
Copy Markdown
Contributor

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 22, 2018

Codecov Report

Merging #2562 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2562   +/-   ##
=======================================
  Coverage   44.59%   44.59%           
=======================================
  Files          95       95           
  Lines       10007    10007           
=======================================
  Hits         4463     4463           
  Misses       4822     4822           
  Partials      722      722
Flag Coverage Δ
#linux 48.4% <ø> (ø) ⬆️
#windows 41.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a8c94...4f644db. Read the comment docs.

Signed-off-by: Michael Crosby <[email protected]>
@dmcgowan
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 248ff06 into containerd:master Aug 22, 2018
@crosbymichael crosbymichael deleted the console branch August 22, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants