Skip to content

Export content service New#2559

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
crosbymichael:exp-content
Aug 22, 2018
Merged

Export content service New#2559
AkihiroSuda merged 1 commit intocontainerd:masterfrom
crosbymichael:exp-content

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Closes #2441

Signed-off-by: Michael Crosby [email protected]

Closes containerd#2441

Signed-off-by: Michael Crosby <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2559 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2559   +/-   ##
=======================================
  Coverage   44.59%   44.59%           
=======================================
  Files          95       95           
  Lines       10007    10007           
=======================================
  Hits         4463     4463           
  Misses       4822     4822           
  Partials      722      722
Flag Coverage Δ
#linux 48.4% <ø> (ø) ⬆️
#windows 41.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f42445...e5115c3. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member Author

crosbymichael commented Aug 22, 2018

@AkihiroSuda i was talking with @dmcgowan yesterday. Maybe we can move all the registrations to the services/server. what do you think?

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 22, 2018

@crosbymichael per your last comment do you still want this merged or will that change applicability of this PR?

@crosbymichael
Copy link
Copy Markdown
Member Author

It can be merged

@AkihiroSuda AkihiroSuda merged commit 1a96db4 into containerd:master Aug 22, 2018
@AkihiroSuda
Copy link
Copy Markdown
Member

Maybe we can move all the registrations to the services/server.

It seems to decrease configurability

@crosbymichael crosbymichael deleted the exp-content branch August 22, 2018 15:14
@dmcgowan
Copy link
Copy Markdown
Member

It seems to decrease configurability

We will always have the way to disable the "built-in" plugins via configuration as well as include new plugins and make them the default. Currently we don't have this level of configurability for content but I think we should feel comfortable centralizing the built in registrations without affecting user configurability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants