[release/1.1] Cherrypick "Set gid 0 when no group is specified" and docs update#2556
Merged
dmcgowan merged 2 commits intocontainerd:release/1.1from Aug 20, 2018
Merged
Conversation
This change is to match Docker's implementaion of setting gid and groups to 0 when no gid is specified but an explicit uid is set. Fixes containerd#2527 Signed-off-by: Michael Crosby <[email protected]> Signed-off-by: Phil Estes <[email protected]>
The behaviour was changed in 99df1a9 ("Set gid 0 when no group is specified"), part of containerd#2529. Take the opportunity to tighten up the grammar a bit too. Signed-off-by: Ian Campbell <[email protected]> Signed-off-by: Phil Estes <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.1 #2556 +/- ##
============================================
Coverage 50.11% 50.11%
============================================
Files 75 75
Lines 7297 7297
============================================
Hits 3657 3657
Misses 2965 2965
Partials 675 675
Continue to review full report at Codecov.
|
Member
|
LGTM |
Member
|
I'll draft the release note after this get merged. |
Member
|
LGTM |
This was referenced Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick commits from #2529 and #2535 for the 1.1.x branch