Add opt for default unix device permissions#2549
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Aug 15, 2018
Merged
Conversation
These opts either inherit the parent cgroup device.list or append the default unix devices like /dev/null /dev/random so that the container has access. Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
default-devices
branch
from
9bc2755 to
b67ea85
Compare
Codecov Report
@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
- Coverage 44.93% 44.59% -0.34%
==========================================
Files 95 95
Lines 9933 10007 +74
==========================================
Hits 4463 4463
- Misses 4748 4822 +74
Partials 722 722
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These opts either inherit the parent cgroup device.list or append the
default unix devices like /dev/null /dev/random so that the container
has access.
Signed-off-by: Michael Crosby [email protected]