Skip to content

Move content.Fetch configuration to struct#2542

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:fetch-config
Aug 9, 2018
Merged

Move content.Fetch configuration to struct#2542
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:fetch-config

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

This makes it easier for callers to call this function and populate the
config without relying on specific flags across commands.

Signed-off-by: Michael Crosby [email protected]

This makes it easier for callers to call this function and populate the
config without relying on specific flags across commands.

Signed-off-by: Michael Crosby <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2542 into master will decrease coverage by 4.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2542      +/-   ##
==========================================
- Coverage   49.08%   44.78%   -4.31%     
==========================================
  Files          86       95       +9     
  Lines        7780     9966    +2186     
==========================================
+ Hits         3819     4463     +644     
- Misses       3244     4781    +1537     
- Partials      717      722       +5
Flag Coverage Δ
#linux 48.65% <ø> (-0.44%) ⬇️
#windows 41.57% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
oci/spec.go 60% <0%> (-9.24%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/compression/compression.go 42.64% <0%> (-8.27%) ⬇️
content/local/writer.go 52.63% <0%> (-7.37%) ⬇️
archive/tar.go 43.13% <0%> (-6.87%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9eeaa1...3be457d. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Aug 9, 2018

LGTM

@dmcgowan dmcgowan merged commit 037fc5e into containerd:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants