switch shim log Windows client/server direction#2536
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Aug 8, 2018
Merged
switch shim log Windows client/server direction#2536crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Contributor
Author
|
@crosbymichael - PTAL |
Switches the client/server direction of the shim-log pipe on Windows so that the shim is the listener. This allows the containerd client to reconnect as needed to the log streams. Signed-off-by: Justin Terry (VM) <[email protected]>
jterry75
force-pushed
the
fix_log_pipe_windows
branch
from
97878dc to
8362d9a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2536 +/- ##
=======================================
Coverage 45.05% 45.05%
=======================================
Files 94 94
Lines 9796 9796
=======================================
Hits 4414 4414
Misses 4662 4662
Partials 720 720
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the client/server direction of the shim-log pipe on Windows so
that the shim is the listener. This allows the containerd client to
reconnect as needed to the log streams.
Signed-off-by: Justin Terry (VM) [email protected]