oci: Update docs for oci.WithUserID#2535
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2535 +/- ##
=======================================
Coverage 45.05% 45.05%
=======================================
Files 94 94
Lines 9796 9796
=======================================
Hits 4414 4414
Misses 4662 4662
Partials 720 720
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I think the new wording can be misunderstood, as a direct reading is "sets the requested uid and gid to zero" meaning both will be set to zero. I think to be clearer it needs separate clauses: "sets the requested uid, additionally sets the gid to 0, and does not return an error."
There was a problem hiding this comment.
Bah, I reworded it several times to avoid exactly that but clearly ended up with a blind spot. I like your wording, will update.
The behaviour was changed in 99df1a9 ("Set gid 0 when no group is specified"), part of containerd#2529. Take the opportunity to tighten up the grammar a bit too. Signed-off-by: Ian Campbell <[email protected]>
|
LGTM |
4 participants
The behaviour was changed in 99df1a9 ("Set gid 0 when no group is
specified"), part of #2529.
Take the opportunity to tighten up the grammar a bit too.
Signed-off-by: Ian Campbell [email protected]