Skip to content

docs: man: rename config.toml(5) to be more descriptive#2534

Merged
estesp merged 1 commit intocontainerd:masterfrom
cyphar:manpage-rename
Aug 8, 2018
Merged

docs: man: rename config.toml(5) to be more descriptive#2534
estesp merged 1 commit intocontainerd:masterfrom
cyphar:manpage-rename

Conversation

@cyphar
Copy link
Copy Markdown
Contributor

@cyphar cyphar commented Aug 8, 2018

The man page namespace is global, so in order to avoid colliding with
other man pages named "config.toml" rename ours to be more descriptive.
This also helps with discoverability (now tab-completion of 'man
containerd' will return the config man page), as well as making it
much cleaner from the perspective of distributions that want to package
containerd.

Signed-off-by: Aleksa Sarai [email protected]

The man page namespace is global, so in order to avoid colliding with
other man pages named "config.toml" rename ours to be more descriptive.
This also helps with discoverability (now tab-completion of 'man
containerd<tab>' will return the config man page), as well as making it
much cleaner from the perspective of distributions that want to package
containerd.

Signed-off-by: Aleksa Sarai <[email protected]>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 8, 2018

Codecov Report

Merging #2534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2534   +/-   ##
=======================================
  Coverage   45.05%   45.05%           
=======================================
  Files          94       94           
  Lines        9796     9796           
=======================================
  Hits         4414     4414           
  Misses       4662     4662           
  Partials      720      720
Flag Coverage Δ
#linux 49.08% <ø> (ø) ⬆️
#windows 41.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba4aa0...7aa132f. Read the comment docs.

@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 8, 2018

Thanks @cyphar; makes sense.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 97473ed into containerd:master Aug 8, 2018
@cyphar cyphar deleted the manpage-rename branch August 11, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants