Update multi-arch image tests#2520
Merged
estesp merged 1 commit intocontainerd:masterfrom Aug 1, 2018
Merged
Conversation
Ensure the test pull for all platforms uses a multi-arch image Use the pause container for testing specific platforms Update the image unpack test to be explicit about the platform to unpack Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2520 +/- ##
=======================================
Coverage 45.07% 45.07%
=======================================
Files 93 93
Lines 9780 9780
=======================================
Hits 4408 4408
Misses 4654 4654
Partials 718 718
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the tests to be more resilient to problems with the official Docker hub images having a periodic incomplete set of architectures. The K8s pause container is a more stable choice for testing the pull of specific architectures. Continue using the busybox image for all platform pull test since the set of architectures does not need to be fixed. Update the pull test to be explicit about expecting to pull and unpack for linux/amd64.