Fix loss of CRI test failure status in CI #2517
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2517 +/- ##
=======================================
Coverage 45.07% 45.07%
=======================================
Files 93 93
Lines 9780 9780
=======================================
Hits 4408 4408
Misses 4654 4654
Partials 718 718
Continue to review full report at Codecov.
|
| @@ -74,8 +74,13 @@ script: | |||
| sudo PATH=$PATH containerd -log-level debug &> /tmp/containerd-cri.log & | |||
| sudo ctr version ; | |||
| sudo PATH=$PATH GOPATH=$GOPATH critest --runtime-endpoint=/var/run/containerd/containerd.sock --parallel=8 ; | |||
There was a problem hiding this comment.
sudo PATH=$PATH GOPATH=$GOPATH critest --runtime-endpoint=/var/run/containerd/containerd.sock --parallel=8 || travis_terminate 1 ?
There was a problem hiding this comment.
That would not allow us to dump the log as it exits immediately
|
LGTM but Travis didn't run... |
estesp
force-pushed
the
fix-travis-script
branch
from
6c724a9 to
9d43cea
Compare
|
bummer; the in-line comments broke travis YML parsing; removed them |
estesp
changed the title
|
Still figuring out the right solution; don't merge yet |
Prior PR fixed the wrong use of `exit` built-in within a Travis script, but lost the reporting of a failure result of CRI testing in the process. Signed-off-by: Phil Estes <[email protected]>
estesp
force-pushed
the
fix-travis-script
branch
from
9d43cea to
9622369
Compare
estesp
changed the title
|
Ok, I think we're good. Unless someone feels the need to inject failures to verify :) |
|
LGTM |
1 similar comment
|
LGTM |
Prior PR fixed the wrong use of
exitbuilt-in within a Travis script,but lost the reporting of a failure result of CRI testing in the process.
Signed-off-by: Phil Estes [email protected]
Fixes: #2515