Runtime v2 absolute shim path to executable#2514
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Jul 31, 2018
Merged
Conversation
Fixes an issue where the runtime v2 was not using an absolute path to the executable but setting the .Dir field on the exec.Cmd. This causes the executable to need to be relative to .Dir but no shim is actually copied to the bundle directory that its work dir is set to. Signed-off-by: Justin Terry (VM) <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2514 +/- ##
=========================================
+ Coverage 45.07% 45.1% +0.03%
=========================================
Files 93 93
Lines 9780 9780
=========================================
+ Hits 4408 4411 +3
+ Misses 4654 4652 -2
+ Partials 718 717 -1
Continue to review full report at Codecov.
|
Member
|
LGTM windows not not always return an ABS path on lookup and this is safe to call again on unix. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the runtime v2 was not using an absolute path to
the executable but setting the .Dir field on the exec.Cmd. This causes
the executable to need to be relative to .Dir but no shim is actually
copied to the bundle directory that its work dir is set to.
Signed-off-by: Justin Terry (VM) [email protected]