Fix for empty platform#2513
Conversation
The default platform had previously been provided using the empty string. This change ensures that the platforms field is always filled in correctly and empty string is properly interpreted. Signed-off-by: Derek McGowan <[email protected]>
|
Don't we need platform in I think that is where the thing is broken. |
Replace manual image struct creation with the image constructor which is there to do just that. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2513 +/- ##
=======================================
Coverage 45.07% 45.07%
=======================================
Files 93 93
Lines 9780 9780
=======================================
Hits 4408 4408
Misses 4654 4654
Partials 718 718
Continue to review full report at Codecov.
|
|
LGTM |
|
LGTM |
|
The busybox image is currently broken on hub, will update appveyor build and merge after it is fixed |
|
Actually, going to merge it now. The master build already broke because of this, I will kick off the master build once the image is fixed upstream. |
|
LGTM |
5 participants
The default platform had previously been provided using the empty string. This change ensures that the platforms field is always filled in correctly and empty string is properly interpreted.
Also replace manual image struct creation with the image constructor which is there to do just that.
Fixes image objects returned by the client using an empty platform because the platform was empty on the image struct.
Also fixes an unintentional break in client backwards compatibility used by some tests. These uses can also be updated to remove
WithPlatformor explicitly set the default.