Add nvidia Opts to lookup containerd binary or hook path#2512
Add nvidia Opts to lookup containerd binary or hook path#2512mlaventure merged 1 commit intocontainerd:masterfrom
Conversation
This is for consumers like Docker that manage a `docker-containerd`. Signed-off-by: Michael Crosby <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2512 +/- ##
=======================================
Coverage 44.99% 44.99%
=======================================
Files 93 93
Lines 9585 9585
=======================================
Hits 4313 4313
Misses 4577 4577
Partials 695 695
Continue to review full report at Codecov.
|
|
LGTM |
| } | ||
|
|
||
| // WithLookupOCIHookPath sets the hook path for the binary via a binary name | ||
| func WithLookupOCIHookPath(name string) Opts { |
There was a problem hiding this comment.
Any reason not to do LookPath all the time and avoid 2 options?
There was a problem hiding this comment.
😹
Sure, but with lookup path at least they know they have an error early, no?
There was a problem hiding this comment.
i mean, don't give a path if you don't know the path, else use the lookup opt
There was a problem hiding this comment.
Yeah, I got it, I'm just considering the PBKAC. But I guess options don't cost a thing
5 participants
This is for consumers like Docker that manage a
docker-containerd.Signed-off-by: Michael Crosby [email protected]