Skip to content

Remove reference to WithExit in README#2507

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
flx42:fix-readme-runtime-v2
Jul 30, 2018
Merged

Remove reference to WithExit in README#2507
crosbymichael merged 1 commit intocontainerd:masterfrom
flx42:fix-readme-runtime-v2

Conversation

@flx42
Copy link
Copy Markdown
Contributor

@flx42 flx42 commented Jul 27, 2018

This function was removed from the containerd package in da1b547

Signed-off-by: Felix Abecassis [email protected]

This function was removed from the containerd package in da1b547

Signed-off-by: Felix Abecassis <[email protected]>
@flx42
Copy link
Copy Markdown
Contributor Author

flx42 commented Jul 27, 2018

But maybe you want to delay this change, since the README is a landing point and people might still using the older API.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2507 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2507   +/-   ##
=======================================
  Coverage   44.74%   44.74%           
=======================================
  Files          93       93           
  Lines        9559     9559           
=======================================
  Hits         4277     4277           
  Misses       4589     4589           
  Partials      693      693
Flag Coverage Δ
#linux 48.95% <ø> (ø) ⬆️
#windows 41.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985920c...e22f196. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

LGTM

I think the README should reflect the current code. Not sure what replaces that functionality though

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit e8f7c2a into containerd:master Jul 30, 2018
@estesp
Copy link
Copy Markdown
Member

estesp commented Jul 30, 2018

Adding this here for posterity because I was curious:

It was replaced during the v2 runtime PR; now the client side implementation in ctr tasks (and test code) has a non-exported options helper: https://github.com/containerd/containerd/blob/master/cmd/ctr/commands/tasks/checkpoint.go#L77-L101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants