Remove reference to WithExit in README#2507
Conversation
This function was removed from the containerd package in da1b547 Signed-off-by: Felix Abecassis <[email protected]>
|
But maybe you want to delay this change, since the README is a landing point and people might still using the older API. |
Codecov Report
@@ Coverage Diff @@
## master #2507 +/- ##
=======================================
Coverage 44.74% 44.74%
=======================================
Files 93 93
Lines 9559 9559
=======================================
Hits 4277 4277
Misses 4589 4589
Partials 693 693
Continue to review full report at Codecov.
|
|
LGTM I think the README should reflect the current code. Not sure what replaces that functionality though |
|
LGTM |
|
Adding this here for posterity because I was curious: It was replaced during the v2 runtime PR; now the client side implementation in |
This function was removed from the containerd package in da1b547
Signed-off-by: Felix Abecassis [email protected]