Add WithImageConfigArgs to replace CMD on image#2505
Merged
estesp merged 1 commit intocontainerd:masterfrom Jul 27, 2018
Merged
Add WithImageConfigArgs to replace CMD on image#2505estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
This allows users to provide args for the process arguments while creating the base spec with an image. It provides the same symantics as Docker where additional args replace the CMD while leaving the ENTRYPOINT the same. Signed-off-by: Michael Crosby <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2505 +/- ##
==========================================
- Coverage 44.76% 44.74% -0.02%
==========================================
Files 93 93
Lines 9555 9559 +4
==========================================
Hits 4277 4277
- Misses 4585 4589 +4
Partials 693 693
Continue to review full report at Codecov.
|
ijc
approved these changes
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to provide args for the process arguments while
creating the base spec with an image. It provides the same symantics as
Docker where additional args replace the CMD while leaving the
ENTRYPOINT the same.
Signed-off-by: Michael Crosby [email protected]