ctr: add new metrics subcommand#2504
Conversation
samuelkarp
force-pushed
the
ctr-t-metrics
branch
from
559eb57 to
114b03d
Compare
This AppVeyor failure looks unrelated to my change. |
There was a problem hiding this comment.
I think we usually use a tabwriter for this, it makes it a little cleaner
There was a problem hiding this comment.
Maybe add a flag, --format that will dump the raw object as json for people that want everything?
There was a problem hiding this comment.
Do you mean --format=json and --format=table or something like that?
Signed-off-by: Samuel Karp <[email protected]>
samuelkarp
force-pushed
the
ctr-t-metrics
branch
2 times, most recently
from
5fc407a to
6410d28
Compare
Codecov Report
@@ Coverage Diff @@
## master #2504 +/- ##
=======================================
Coverage 44.74% 44.74%
=======================================
Files 93 93
Lines 9559 9559
=======================================
Hits 4277 4277
Misses 4589 4589
Partials 693 693
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
you don't need Destination at all with cli
Signed-off-by: Samuel Karp <[email protected]>
samuelkarp
force-pushed
the
ctr-t-metrics
branch
from
6410d28 to
9a34bb0
Compare
|
LGTM |
4 participants
This is a very simple new subcommand to
ctr tasksthat just displays a few metrics from a given container task. I wrote this as I was trying to understand how to deserialize a*types.Metric.Data, which is a*google_protobuf1.Anyand there wasn't already an example inctr.I just picked a format and selected a few fields to display; happy to change any of these.