Update containerd dependencies for 1.2#2500
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Jul 26, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2500 +/- ##
=======================================
Coverage 44.76% 44.76%
=======================================
Files 93 93
Lines 9555 9555
=======================================
Hits 4277 4277
Misses 4585 4585
Partials 693 693
Continue to review full report at Codecov.
|
dmcgowan
reviewed
Jul 25, 2018
Member
There was a problem hiding this comment.
I don't mean to impose a process on you that we don't follow anywhere else, but since we are moving from tag to hash, do you think putting a comment that indicates something like # v1.0.1 +5 commits or something like that would be helpful?
Contributor
There was a problem hiding this comment.
If a comment is desired perhaps the output of git describe would be appropriate? e.g.
$ git describe d810dbc60d8c5aeeb3d054bd1132fab2121968ce
v1.0.1-43-gd810dbc
Member
|
LGTM A nit comment but feel free to ignore |
Signed-off-by: Michael Crosby <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Crosby [email protected]