Skip to content

Add content ingests to lease and gc#2496

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:lease-content-uploads
Jul 31, 2018
Merged

Add content ingests to lease and gc#2496
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:lease-content-uploads

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

Allow content ingests to be cleaned up during gc. Use a default expiration on content ingests or make use of the lease expiration when provided.

closes #2400

@dmcgowan dmcgowan force-pushed the lease-content-uploads branch from 08ba16b to 1accdf8 Compare July 25, 2018 23:21
Allow content ingests to be cleaned up during gc.
Use a default expiration on content ingests or make
use of the lease expiration when provided.

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan force-pushed the lease-content-uploads branch from 1accdf8 to dfc9991 Compare July 25, 2018 23:54
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2496 into master will increase coverage by 0.03%.
The diff coverage is 41.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2496      +/-   ##
==========================================
+ Coverage   44.76%   44.79%   +0.03%     
==========================================
  Files          93       93              
  Lines        9555     9748     +193     
==========================================
+ Hits         4277     4367      +90     
- Misses       4585     4664      +79     
- Partials      693      717      +24
Flag Coverage Δ
#linux 49.02% <44.64%> (+0.03%) ⬆️
#windows 41.17% <41.28%> (+0.13%) ⬆️
Impacted Files Coverage Δ
metadata/buckets.go 56.33% <ø> (ø) ⬆️
content/local/store.go 48.76% <0%> (-2.8%) ⬇️
metadata/db.go 64.98% <100%> (ø) ⬆️
metadata/content.go 40.5% <33.75%> (+1.17%) ⬆️
metadata/leases.go 42.21% <50%> (+1.6%) ⬆️
metadata/gc.go 61.35% <55.55%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02728f...dfc9991. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@dmcgowan dmcgowan added this to the 1.2 milestone Jul 30, 2018
@ehazlett
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit d0ab8c8 into containerd:master Jul 31, 2018
@dmcgowan dmcgowan deleted the lease-content-uploads branch September 10, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GC support for content ingests

4 participants