Add sync option to lease removal#2493
Merged
estesp merged 2 commits intocontainerd:masterfrom Jul 31, 2018
Merged
Conversation
Signed-off-by: Derek McGowan <[email protected]>
Ensure delete returns a typed error on not found Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
sync-lease-removal
branch
from
254bfe1 to
b760cee
Compare
Codecov Report
@@ Coverage Diff @@
## master #2493 +/- ##
=========================================
+ Coverage 44.76% 44.8% +0.04%
=========================================
Files 93 93
Lines 9555 9557 +2
=========================================
+ Hits 4277 4282 +5
+ Misses 4585 4583 -2
+ Partials 693 692 -1
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sync option to lease deletion similar to image removal. This both provides a way to ensure synchronous cleanup of objects only referenced by a lease and an alternate way of triggering the garbage collector without requiring creating of a top level object like images.
This change required an API addition and I also included an 2 API error changes
syncoption to lease deletion API, this is optional and backwards compatibleon anyone who was creating leases themselves and checking the error with the expectation of
this behavior. This should be low impact and anyone using the containerd go client will not be impacted.
impact a client which had custom behavior expecting an unknown error on already exists. The client
by default generates random ids making this change very low impact.