Skip to content

native: set '/' permission to 0755#2485

Merged
estesp merged 1 commit intocontainerd:masterfrom
AkihiroSuda:fix-native-root-permission
Jul 23, 2018
Merged

native: set '/' permission to 0755#2485
estesp merged 1 commit intocontainerd:masterfrom
AkihiroSuda:fix-native-root-permission

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

Unlike other snapshotters, the permission was previously set to 0700
unexpectedly.

Signed-off-by: Akihiro Suda [email protected]

Fix moby/buildkit#520 (comment)

Unlike other snapshotters, the permission was previously set to 0700
unexpectedly.

Signed-off-by: Akihiro Suda <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2485 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2485      +/-   ##
==========================================
- Coverage   44.77%   44.76%   -0.02%     
==========================================
  Files          93       93              
  Lines        9552     9555       +3     
==========================================
  Hits         4277     4277              
- Misses       4583     4585       +2     
- Partials      692      693       +1
Flag Coverage Δ
#linux 48.98% <0%> (-0.02%) ⬇️
#windows 41.04% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d52c71...7461739. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants