Fix options ordering in proto api txt files#2470
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jul 17, 2018
Merged
Fix options ordering in proto api txt files#2470crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
An upstream change caused the options to now be ordered Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2470 +/- ##
=======================================
Coverage 45.04% 45.04%
=======================================
Files 92 92
Lines 9424 9424
=======================================
Hits 4245 4245
Misses 4496 4496
Partials 683 683
Continue to review full report at Codecov.
|
Member
|
LGTM |
Member
|
Going to merge this one now as its blocking other PRs and its a simple fix for CI based on an upstream ordering change. |
This was referenced Nov 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An upstream change caused the options to now be ordered. Not sure how the order was determined before, but now it is sorted. This may need to be backported or a similar change made in release branches.