Update client Image to have configurable platform#2468
Merged
estesp merged 1 commit intocontainerd:masterfrom Jul 31, 2018
Merged
Update client Image to have configurable platform#2468estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Member
|
Need to rebase on master |
dmcgowan
force-pushed
the
set-platform-on-unpack
branch
from
9c6ff97 to
2a5f476
Compare
Separate Fetch and Pull commands in client to distinguish between platform specific and non-platform specific operations. `ctr images pull` with all platforms will now unpack all platforms. `ctr content fetch` now supports platform flags. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
set-platform-on-unpack
branch
from
2a5f476 to
3a916a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2468 +/- ##
=========================================
+ Coverage 41.33% 45.03% +3.7%
=========================================
Files 66 92 +26
Lines 7869 9425 +1556
=========================================
+ Hits 3253 4245 +992
- Misses 4108 4497 +389
- Partials 508 683 +175
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate Fetch and Pull commands in client to distinguish between platform specific and non-platform specific operations.
ctr images pullwith all platforms will now unpack all platforms.ctr content fetchnow supports platform flags.This enables using the client to unpack on a specified platform which is useful for cross compilation in buildkit or using the client to drive a container/filesystem on a different platform.