build: include instructions for runc build#2460
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jul 13, 2018
Merged
build: include instructions for runc build#2460crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
stevvooe
force-pushed
the
runc-build-instructions
branch
from
55e15ea to
dd104de
Compare
estesp
approved these changes
Jul 12, 2018
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
one minor wording change; looks good
dmcgowan
reviewed
Jul 12, 2018
Member
There was a problem hiding this comment.
nit: sometimes it is necessary
Codecov Report
@@ Coverage Diff @@
## master #2460 +/- ##
=======================================
Coverage 45.04% 45.04%
=======================================
Files 92 92
Lines 9424 9424
=======================================
Hits 4245 4245
Misses 4496 4496
Partials 683 683
Continue to review full report at Codecov.
|
Including some build information about runc that has been helpful in my development environment. This should allow one to build and install runc next to containerd so that both can be worked on simultaneously. Signed-off-by: Stephen Day <[email protected]>
stevvooe
force-pushed
the
runc-build-instructions
branch
from
dd104de to
a5e0916
Compare
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including some build information about runc that has been helpful in my
development environment. This should allow one to build and install runc
next to containerd so that both can be worked on simultaneously.
Signed-off-by: Stephen Day [email protected]